ToNullifier to ToInputNoteCommitment #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: This doesn't yet change the kernel to use the |
hackaugusto
force-pushed
the
hacka-tonullifier-to-toinputnotecommitment
branch
from
a4ff4da to
e2ac30b
Compare
hackaugusto
changed the title
hackaugusto
force-pushed
the
hacka-tonullifier-to-toinputnotecommitment
branch
from
e2ac30b to
b501b9e
Compare
bobbinth
approved these changes
Jun 6, 2024
hackaugusto
force-pushed
the
hacka-tonullifier-to-toinputnotecommitment
branch
from
b501b9e to
4a89424
Compare
hackaugusto
force-pushed
the
hacka-tonullifier-to-toinputnotecommitment
branch
from
4a89424 to
6d70e27
Compare
bobbinth
approved these changes
Jun 7, 2024
Dominik1999
pushed a commit
that referenced
this pull request
Jun 12, 2024
bobbinth
pushed a commit
that referenced
this pull request
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up to #726
Instead of removing the
ToNullifiertrait, this replaces said trait withToInputNoteCommitment. The change is mainly the additional of theOption<NoteId>, which will be used by #353 .The decision to keep the trait is due to code reuse. Mainly of the
NoteInputswhich does the validation for the number of inputs and computes the input notes commitment. The alternative of using a wrapper type ended duplicating validation code, when I tried to remove the duplicated the error handling become worse and introducedunwraps. Keeping the trait eliminates these concerns.