-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add NoteFile
object
#721
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you! I left a couple of small comments inline. Once these are addressed, we can merge.
Also, let's update the changelog.
Oh - one other potential improvement that came to mind: maybe we should implement |
If not too much of an issue we might want to test serialization as well, but it could come later. |
Based on the discussion in 0xPolygonMiden/miden-client#354 (comment), I wonder if we should add |
Just read the issue discussion and had a question about this new variant. Is the idea to just serialize the If that's the case, when would the rest of the information be filled in on the client? When importing or after a sync? |
Yes, but I'd probably call the variant
In this case, I'm thinking the client would make a request to the node to get the details, and if nothing comes back return an error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you! I left a couple more small comments inline. Also, adding a simple test serialization/deserialization may be good.
Lastly, let's resolve the merge conflict for changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good! Thank you!
closes #715
This PR adds a
NoteFile
object to represent serialized notes.