Implement CompiledTransaction #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frisitano
force-pushed
the
frisitano-compiled-transaction
branch
from
86fffaa to
e8490bd
Compare
bobbinth
reviewed
Mar 2, 2023
frisitano
force-pushed
the
frisitano-compiled-transaction
branch
from
e8490bd to
e06084e
Compare
bobbinth
approved these changes
Mar 2, 2023
daedlock
pushed a commit
to keomprotocol/miden-base
that referenced
this pull request
Feb 8, 2024
…nMiden#47) * TransactionQueueTrait * StateViewTrait * txqueue: add_transaction * impl TxQueueTrait * batch builder * fmt & clippy * Rename TransactionQueue * Rename BatchBuilder * Rename StateView to TransactionVerifier * Txqueue: remove get_transactions() * rename trait methods * StateView -> TV * TxQueue: send_batches scaffold * tx queue pushes batches * BatchBuilder::add_batches * Remove state_view mod * block_builder mod * BatchBuilder: change to add_tx_groups * BlockBuilder::add_batches * BatchBuilder uses BlockProducer * SharedProvenTx type * SharedRwVec type * always send batch to block builder, even if empty * batch builder: max_batches_per_block param * sections * TransactionBatch::updated_accounts * confirm_at_most_one_tx_per_account * fmt * TxBatch: consumed_notes_script_roots * docs * transaction batch: created_notes_hashes * transaction batch: consumed_notes_nullifiers * make errors concrete * Rename to build_batch * build_batch * Rename build_block * refactor batch builder * clippy * dep order * tx queue: rename param * txqueue tests * test_utils: DummyProvenTxGenerator * test_build_batch_success * test_tx_verify_failure * test_build_batch_failure * fmt * batch builder: first test * change `BlockBuilder::build_block()` signature * SharedTxBatch type * remove useless test type * test 2 * test 3 * revert `build_block()` taking an `Option` * fix comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
CompiledTransactionobject.closes: #45