feat: introduce create_note kernel procedure auth

[frisitano]

This PR introduces authentication for the create_note kernel procedure. We modify tests to account for the updated auth pattern and introduce some new tests as well as a few minor comment updates.

closes: #218 #79

[frisitano]

I started out with this logic defined in a procedure at the top of this source file using the context import:

use.context::account_*

proc.create_note_wrapper
      call.account_*::create_note
      drop dropw dropw
end

This was also defined at the top of the source file in note_2_script_src. This led to a strange bug which I suspect is related to compiler cache collision or some other form of unexpected behaviour which I haven't had time to investigate (I already lost a lot of time battling this). Migrating to the hex specifier of the account procedure fixed things.

[bobbinth]

I think using hex-based calling convention is the right approach here and I've created 0xPolygonMiden/miden-vm#1071 to improve support for this. But it is a little concerning that there was this odd behavior in the first place. Do you think it would be possible to create a minimal reproducible example of this in Miden VM? If we have such an example, I should be able to debug this relatively quickly.

[frisitano]

Sure thing, I will try and recreate an example.

[frisitano]

Here is an example of the failure case for the transaction in which we use different names for the procedures at the top of each note script:

frisitano-create-note-auth...frisitano-assembler-error

This actually compiles and runs but fails an assertion error which I wasn't able to track down. I wouldn't expect a failed assertion as the logic should be the same.

Here is a problem related to procedure name collisions in different scripts when compiled using the same AssemblyContext:

0xPolygonMiden/miden-vm@next...frisitano-assembler-proc-collisions

[frisitano]

When I inline the call operation it works fine so maybe it's something to do with the way that call operations are inlined when invoked via procedures?

This works fine:
frisitano-create-note-auth...frisitano-assembler-bug-2

[bobbinth]

Looks good! Thank you! I left a note about the odd behavior with the note scripts.

Other than that, this PR should be merged after #236 is merged (which itself is waiting for 0xPolygonMiden/miden-vm#1070 to be merged).

[bobbinth]

I think using hex-based calling convention is the right approach here and I've created 0xPolygonMiden/miden-vm#1071 to improve support for this. But it is a little concerning that there was this odd behavior in the first place. Do you think it would be possible to create a minimal reproducible example of this in Miden VM? If we have such an example, I should be able to debug this relatively quickly.