feat: adding a simple masm wallet an eoa #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
reviewed
Sep 8, 2023
bobbinth
requested changes
Sep 11, 2023
bobbinth
reviewed
Sep 12, 2023
Dominik1999
force-pushed
the
dominik_add_basic_asm_wallet_new_try
branch
from
51ef703 to
229c173
Compare
bobbinth
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
All looks good! Thank you! I left a couple of nits inline. Once these are addressed and we rebase from #236 (I think @hackaugusto is almost done with it), it is good to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22 and is a new version of #213
This PR implements a basic wallet interface. For now, we only have
receive_asset,send_asset.Tests are working and test basic functionality.
receive_assetand the account in fact has the asset in its vault after the transactionsend_assetand the account doesn't have the asset in its vault after the transaction [Note: here is missing that we don't actually have a note at the end of the test, the note is stored in memory of the account]Also the basic eoa
auth_txprocedure only increases the nonce. The Falcon signature verification is not there yet. @Al-Kindi-0