feat: removed external dependencies from miden-lib #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 27, 2025
crates/miden-lib/src/note/utils.rs
Outdated
Comment on lines
1
to
3
| use crate::note::{ | ||
| scripts, AccountId, Asset, NoteError, NoteExecutionMode, NoteInputs, NoteRecipient, NoteTag, | ||
| NoteType, Word, |
There was a problem hiding this comment.
I think #1145 is just about replacing import with re-exports from the root. Here writing use crate::note::{...} is the same as use super::{...}, which I don't think is desirable.
So I think we should only replace imports with crate imports when that import is re-exported at the root, i.e. if we can do use crate::{...}.
bobbinth
added
the
no changelog
PhilippGackstatter
approved these changes
Mar 5, 2025
Comment on lines
4
to
8
| use miden_objects::{note::NoteMetadata, AccountDeltaError, AssetError, Digest, Felt, NoteError}; | ||
| use miden_objects::{note::NoteMetadata, AccountDeltaError, AssetError, NoteError}; | ||
| use thiserror::Error; | ||
|
|
||
| use crate::transaction::{Digest, Felt}; | ||
|
|
There was a problem hiding this comment.
I would revert this change. It's fine to import from miden_objects as well.
varun-doshi
force-pushed
the
varun/deps-lib
branch
from
b35b49a to
5785daf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1145
removed external dependencies from miden-lib