Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: missing BlockNumber s #1080

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

SantiagoPittella
Copy link
Collaborator

closes #1077

docs: update changelog
@SantiagoPittella SantiagoPittella force-pushed the santiagopittella-missing-block-numbers branch from 673f508 to 4edc96a Compare January 17, 2025 17:57
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@bobbinth bobbinth requested a review from igamigo January 17, 2025 18:10
Copy link
Collaborator

@igamigo igamigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I could only find one missing replacement on create_p2idr_note (the recall_height parameter)

@SantiagoPittella SantiagoPittella merged commit 801f18e into next Jan 17, 2025
11 checks passed
@SantiagoPittella SantiagoPittella deleted the santiagopittella-missing-block-numbers branch January 17, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants