Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script inputs to note object #9

Closed
Tracked by #29
bobbinth opened this issue Dec 24, 2022 · 0 comments · Fixed by #32
Closed
Tracked by #29

Add script inputs to note object #9

bobbinth opened this issue Dec 24, 2022 · 0 comments · Fixed by #32
Assignees

Comments

@bobbinth
Copy link
Contributor

As mentioned in #7 (reply in thread), it would be beneficial to add one more component to the Note object. This component would define a set of values which would be put on the top of the stack before note scripts start executing. Internally, this would be just a vector of field elements (similar to how we have a vector of assets).

Adding this component would affect how we compute note hash and note nullifier. In both cases, I think we should compute the hash of inputs first, and then include this hash in the note hash and nullifier computations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants