Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kernel masm getters should overwrite stack elements #188

Closed
frisitano opened this issue Aug 4, 2023 · 1 comment
Closed

Kernel masm getters should overwrite stack elements #188

frisitano opened this issue Aug 4, 2023 · 1 comment
Labels
kernels Related to transaction, batch, or block kernels

Comments

@frisitano
Copy link
Contributor

@bobbinth proposed that getters should overwrite elements on the top of the stack. It would then be the responsibility of the caller to pad before invocation. see here: #183 (comment)
@frisitano frisitano mentioned this issue Aug 4, 2023
Merged
daedlock pushed a commit to keomprotocol/miden-base that referenced this issue Feb 8, 2024
@hackaugusto
block_builder: using borrows instead of refcount (0xPolygonMiden#188)
5e811a1
@bobbinth bobbinth added the kernels Related to transaction, batch, or block kernels label May 22, 2024
@bobbinth bobbinth mentioned this issue May 22, 2024
Closed
@bobbinth
Copy link
Contributor

Superseded by #685.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kernels Related to transaction, batch, or block kernels
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frisitano @bobbinth