Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nullifier epoch verification to transaction prologue #105

Open
bobbinth opened this issue May 1, 2023 · 3 comments
Open

Add nullifier epoch verification to transaction prologue #105

bobbinth opened this issue May 1, 2023 · 3 comments
Labels
enhancement New feature or request kernels Related to transaction, batch, or block kernels

Comments

@bobbinth
Copy link
Contributor

bobbinth commented May 1, 2023

To support epoch-based nullifier scheme, we need to verify a mapping between nullifier and an epoch index as described in 0xPolygonMiden/miden-vm#356 (comment). This will require the following changes:

  • Compute the nullifier commitment as a sequential hash of (nullifier, script_root, epoch_index) tuples (vs. current (nullifier, script_root).
  • In the prologue, compute epoch index for each nullifier. Epoch index can be computed based on the block number in which the note was create - but we still need to figure out the exact parameters.
  • Verify that the computed epoch index is greater than or equal to the epoch index provided via the nullifier commitment.
@Dominik1999
Copy link
Collaborator

Should we hold off on this? According to our latest discussion, we might not need to introduce epochs at the beginning.

#106

@Dominik1999
Copy link
Collaborator

Should we not introduce epochs of nullifiers for now? I wanted to update the docs.

@bobbinth
Copy link
Contributor Author

I think we should mention the epoch-based nullifier in the docs as technical people would wonder how we are planning to deal with nullifier DB growth (which would be a real problem for a high TPS system). So, basically, we may hold off on implementing this, but the docs should probably describe the approach (and we can say that initially, we'll have a simplified version of this).

daedlock pushed a commit to keomprotocol/miden-base that referenced this issue Feb 8, 2024
@bobbinth bobbinth added enhancement New feature or request kernels Related to transaction, batch, or block kernels labels Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request kernels Related to transaction, batch, or block kernels
Projects
None yet
Development

No branches or pull requests

2 participants