feat(SMT): reverse mutations generation, mutations serialization #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polydez
changed the title
polydez
changed the title
polydez
commented
Dec 12, 2024
| }, | ||
| Addition(node) => { | ||
| if let Some(old_node) = self.insert_inner_node(index, node) { | ||
| reverse_mutations.insert(index, Addition(old_node)); |
There was a problem hiding this comment.
Here we rely on the computation of mutations set, that it didn't generate useless update where new value is the same as previous (actually it does generate unnecessary changes in mutations set). Otherwise we would need to clone node and compare it with old_node.
polydez
commented
Dec 12, 2024
| for (key, value) in new_pairs { | ||
| self.insert_value(key, value); | ||
| if let Some(old_value) = self.insert_value(key.clone(), value) { | ||
| reverse_pairs.insert(key, old_value); |
There was a problem hiding this comment.
Here we also rely on the computation of mutations set, that it didn't generate useless update where new value is the same as previous (actually it does generate unnecessary changes in mutations set). Otherwise we would need to clone value and compare it with old_value.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to 0xPolygonMiden/miden-node#527
While refactoring account inclusion proofs in-memory storage, I realized that it's very hard to keep persistent state for additional "initial" structure, and it would be easier to keep only reverse mutation sets and the latest state. Thus, we need to store only reverse mutations set, but latest state we can still reconstruct from the database.
In this PR I implemented reverse mutations set generation on mutations applying. Also implemented serialization of mutations set.
The only concern I have is that now we produce reverse mutations set on each applying of mutations set. For the node it's fine, because we always need them after changing of the latest accounts SMT. But if someone else uses our SMT, it might be unnecessary to calculate such reversion on each mutations set applying.