Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signatures benchmarks #354

Merged
merged 29 commits into from
Dec 13, 2024
Merged

Signatures benchmarks #354

merged 29 commits into from
Dec 13, 2024

Conversation

Al-Kindi-0
Copy link
Collaborator

Describe your changes

Adds benchmarks for the implemented DSA-s.

Checklist before requesting a review

  • Repo forked and branch created from next according to naming convention.
  • Commit messages and codestyle follow conventions.
  • Relevant issues are linked in the PR description.
  • Tests added for new functionality.
  • Documentation/comments updated according to changes.

Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you! I left a few small comments inline.

benches/README.md Outdated Show resolved Hide resolved
benches/README.md Outdated Show resolved Hide resolved
benches/README.md Outdated Show resolved Hide resolved
benches/README.md Outdated Show resolved Hide resolved
benches/README.md Outdated Show resolved Hide resolved
@Al-Kindi-0 Al-Kindi-0 force-pushed the al-stark-signature-dev-masm-bench branch from 370da89 to 0075e83 Compare December 11, 2024 14:00
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I left just one non-blocking comment inline.

benches/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good! Thank you!

Base automatically changed from al-stark-signature-dev-masm to rpo-dsa December 13, 2024 03:33
@bobbinth bobbinth merged commit cae87a2 into rpo-dsa Dec 13, 2024
13 checks passed
@bobbinth bobbinth deleted the al-stark-signature-dev-masm-bench branch December 13, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants