Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to new Winterfell #315

Merged
merged 1 commit into from
May 11, 2024
Merged

Migrate to new Winterfell #315

merged 1 commit into from
May 11, 2024

Conversation

Al-Kindi-0
Copy link
Collaborator

Describe your changes

Checklist before requesting a review

  • Repo forked and branch created from next according to naming convention.
  • Commit messages and codestyle follow conventions.
  • Relevant issues are linked in the PR description.
  • Tests added for new functionality.
  • Documentation/comments updated according to changes.

@Al-Kindi-0 Al-Kindi-0 requested a review from bobbinth May 10, 2024 12:34
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

plafer
plafer approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bobbinth
bobbinth approved these changes May 11, 2024
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good! Thank you!

@bobbinth bobbinth marked this pull request as ready for review May 11, 2024 19:05
@bobbinth bobbinth merged commit 137ce32 into next May 11, 2024
11 checks passed
@bobbinth bobbinth deleted the al-migrate-winterfell branch May 11, 2024 19:06
bobbinth pushed a commit that referenced this pull request May 11, 2024
@Al-Kindi-0 @bobbinth
feat: migrate to new Winterfell (#315)
f967211
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbinth bobbinth bobbinth approved these changes

@plafer plafer plafer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Al-Kindi-0 @plafer @bobbinth