-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3/x] Link Miden packages without cross-context calls lifting/lowering #353
Draft
greenhat
wants to merge
17
commits into
greenhat/delete-cargo-component-based-tests
Choose a base branch
from
greenhat/i346-link-pkg-gen-miden-abi
base: greenhat/delete-cargo-component-based-tests
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[3/x] Link Miden packages without cross-context calls lifting/lowering #353
greenhat
wants to merge
17
commits into
greenhat/delete-cargo-component-based-tests
from
greenhat/i346-link-pkg-gen-miden-abi
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 14, 2024
@bitwalker We need high-level type signatures to link a Miden package - #354 |
greenhat
force-pushed
the
greenhat/i346-link-pkg-gen-miden-abi
branch
3 times, most recently
from
November 26, 2024 10:16
3d9b15e
to
56d45c1
Compare
greenhat
changed the base branch from
greenhat/i346-link-lib-package
to
greenhat/delete-cargo-component-based-tests
November 26, 2024 10:16
greenhat
changed the title
[2/2] Link package, preparation for cross-context
[3/x] Link package, preparation for cross-context Nov 26, 2024
call
generationcall
generation
greenhat
changed the title
[3/x] Link package, preparation for cross-context
[3/x] Link Miden package without cross-context calls lifting/lowering
Nov 26, 2024
call
generation
greenhat
changed the title
[3/x] Link Miden package without cross-context calls lifting/lowering
[3/x] Link Miden packages without cross-context calls lifting/lowering
Nov 26, 2024
greenhat
force-pushed
the
greenhat/delete-cargo-component-based-tests
branch
from
November 26, 2024 13:16
2466128
to
73262e3
Compare
and exports and use proper Wasm CM names
Wasm CM names for intrinsics, stdlib, tx kernel.
assembling Library
…ports in basic wallet test
When building a basic wallet Miden package in the p2id test.
greenhat
force-pushed
the
greenhat/i346-link-pkg-gen-miden-abi
branch
from
November 26, 2024 13:17
56d45c1
to
6745c3f
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #351
Close #346
Ref #303
This PR is stacked on the #356 and should be merged after it
This PR links P2ID note script with the basic wallet Miden package, ignoring the lifting/lowering of the cross-context calls. The cross-context calls will be addressed in the subsequent PR(s).
Since this PR contains quite a few changes in various parts of the compiler, I suggest going by commits for the review process.
This PR makes the following decisions:
intrinsics
, etc. modules;Component
will be used in compiler pipeline instead ofModule
and lifting/lowering will be done in separate modules so most likely this workaround will not be necessary#anon
namespace is used with Wasm CM interface (miden:basic-wallet/[email protected]
) resulting in#anon::miden:basic-wallet/[email protected]
string as the export module name;Linker::allow_missing
with linked library's exports (with removed#anon
namespace);