fix accinputhash #1458
Merged
fix accinputhash #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToniRamirezM
approved these changes
Dec 15, 2022
ARR552
changed the base branch from
release/v0.0.1
to
fix/aggregator-address-rc3
ARR552
added a commit
that referenced
this pull request
Dec 15, 2022
* fix: update aggregator proto to send pub address This commit applies the changes introduced to the aggregator proto file. The changes are regarding the GetGenFinalProofRequest message that now needs to send the aggregator public address. * chore: add goreleaser file * Get NewLocalExitRoot and NewStateRoot from last batch in the aggregated proof * feat: add prover IP address This commit adds the prover IP address to the Prover struct. The address is retrieved from the grpc connection and logged alogside the prover ID. * fix: remove ShortID method from Prover This commit removes the ShortID method from the Prover. This because the prover ID can be a fixed arbitrary string and not only a UUID. * fix accinputhash (#1458) * refac: send final proof in FinalProofInputs This commit modifies the FinalProofInputs struct to hold also the final proof. The VerifyBatches signature has been modified accordingly. Co-authored-by: zkronos73 <[email protected]> Co-authored-by: Alonso Rodriguez <[email protected]>
kind84
added a commit
that referenced
this pull request
Dec 16, 2022
* fix: update aggregator proto to send pub address This commit applies the changes introduced to the aggregator proto file. The changes are regarding the GetGenFinalProofRequest message that now needs to send the aggregator public address. * chore: add goreleaser file * Get NewLocalExitRoot and NewStateRoot from last batch in the aggregated proof * feat: add prover IP address This commit adds the prover IP address to the Prover struct. The address is retrieved from the grpc connection and logged alogside the prover ID. * fix: remove ShortID method from Prover This commit removes the ShortID method from the Prover. This because the prover ID can be a fixed arbitrary string and not only a UUID. * fix accinputhash (#1458) * refac: send final proof in FinalProofInputs This commit modifies the FinalProofInputs struct to hold also the final proof. The VerifyBatches signature has been modified accordingly. Co-authored-by: zkronos73 <[email protected]> Co-authored-by: Alonso Rodriguez <[email protected]>
kind84
added a commit
that referenced
this pull request
Dec 16, 2022
* fix: update aggregator proto to send pub address This commit applies the changes introduced to the aggregator proto file. The changes are regarding the GetGenFinalProofRequest message that now needs to send the aggregator public address. * chore: add goreleaser file * Get NewLocalExitRoot and NewStateRoot from last batch in the aggregated proof * feat: add prover IP address This commit adds the prover IP address to the Prover struct. The address is retrieved from the grpc connection and logged alogside the prover ID. * fix: remove ShortID method from Prover This commit removes the ShortID method from the Prover. This because the prover ID can be a fixed arbitrary string and not only a UUID. * fix accinputhash (#1458) * refac: send final proof in FinalProofInputs This commit modifies the FinalProofInputs struct to hold also the final proof. The VerifyBatches signature has been modified accordingly. Co-authored-by: zkronos73 <[email protected]> Co-authored-by: Alonso Rodriguez <[email protected]> Co-authored-by: zkronos73 <[email protected]> Co-authored-by: Alonso Rodriguez <[email protected]>
kind84
added a commit
that referenced
this pull request
Jan 11, 2023
* fix: update aggregator proto to send pub address This commit applies the changes introduced to the aggregator proto file. The changes are regarding the GetGenFinalProofRequest message that now needs to send the aggregator public address. * chore: add goreleaser file * Get NewLocalExitRoot and NewStateRoot from last batch in the aggregated proof * feat: add prover IP address This commit adds the prover IP address to the Prover struct. The address is retrieved from the grpc connection and logged alogside the prover ID. * fix: remove ShortID method from Prover This commit removes the ShortID method from the Prover. This because the prover ID can be a fixed arbitrary string and not only a UUID. * fix accinputhash (#1458) * refac: send final proof in FinalProofInputs This commit modifies the FinalProofInputs struct to hold also the final proof. The VerifyBatches signature has been modified accordingly. Co-authored-by: zkronos73 <[email protected]> Co-authored-by: Alonso Rodriguez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes accinputhash stored by the sequencer
Reviewers
Main reviewers: