Skip to content

Djpolygon/18.04 updates#811

Merged
djpolygon merged 1 commit into
developfrom
djpolygon/18.04Updates
Apr 5, 2023
Merged

Djpolygon/18.04 updates#811
djpolygon merged 1 commit into
developfrom
djpolygon/18.04Updates

Conversation

@djpolygon
Copy link
Copy Markdown
Contributor

…nner is end of life

Description

Please provide a detailed description of what was done in this PR

Changes

  • Bugfix (non-breaking change that solves an issue)
  • [ x] Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@github-advanced-security
Copy link
Copy Markdown

You have successfully added a new Snyk Open Source configuration .github/workflows/security-ci.yml:snyk. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@github-advanced-security
Copy link
Copy Markdown

You have successfully added a new SnykCode configuration .github/workflows/security-ci.yml:snyk-code. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@djpolygon djpolygon changed the base branch from master to develop April 5, 2023 16:41
@cffls cffls changed the base branch from develop to master April 5, 2023 16:42
@cffls cffls changed the base branch from master to develop April 5, 2023 16:42
@djpolygon djpolygon merged commit 7abbf23 into develop Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants