added a write lock to the txs.filter method and a read lock to the tx…#805
Closed
thogard785 wants to merge 1 commit into
Closed
added a write lock to the txs.filter method and a read lock to the tx…#805thogard785 wants to merge 1 commit into
thogard785 wants to merge 1 commit into
Conversation
…s.reheap method - both of which are called by Filter during reorg adjustments to txpool
JekaMas
reviewed
Apr 4, 2023
JekaMas
approved these changes
Apr 4, 2023
JekaMas
reviewed
Apr 4, 2023
| } | ||
| l.txs.m.RLock() | ||
| defer l.txs.m.RUnlock() | ||
| l.txs.reheap() |
Contributor
There was a problem hiding this comment.
Could we remove this Rlock and use that reheap code https://github.com/maticnetwork/bor/pull/806/files#diff-4aae684b15e6df1ff1c22f6845c43bd308a67dc43fc4fdec6f620979ac6941a9R157
16 tasks
Member
|
Thanks @thogard785 for the PR. Have picked your commit against another branch to make a release. Please follow #807 for more details. Closing this for now. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The filter method of txSortedMap is typically called by caller that holds the "m" RWLock object.
During reorgs, however, a Filter method of txList calls the filter method of txSortedMap but does not engage the lock.
This Filter method is called only by the txPool methods demoteUnexecutables and promoteExecutables, which are only called during reorgs (which explains the low frequency with which this crash occurs).
Description
Added in a read lock and a write lock
Changes
Nodes audience
This PR is in response to a validator crash
Checklist
Additional comments
Have not had time to test this yet but it seemed urgent.