internal/ethapi: set rpc gas cap as default gas limit when creating access list#791
Merged
Conversation
pratikspatil024
approved these changes
Mar 27, 2023
anshalshukla
approved these changes
Mar 27, 2023
marcello33
approved these changes
Mar 27, 2023
manav2401
approved these changes
Mar 27, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #791 +/- ##
===========================================
+ Coverage 56.60% 56.65% +0.04%
===========================================
Files 610 610
Lines 71266 71572 +306
===========================================
+ Hits 40339 40546 +207
- Misses 27466 27550 +84
- Partials 3461 3476 +15
... and 21 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR, while creating access list we default to rpc gas cap when gas limit isn't provided in the transaction args instead of re-estimating for every list. See ethereum/go-ethereum#25467
Changes
Checklist
Testing