Skip to content

chg : Move some info/error logs to debug #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0xsharma merged 8 commits into from
Feb 14, 2023
Merged

chg : Move some info/error logs to debug #673

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3c27340
chg : commit tx logs from info to debug
0xsharma Jan 16, 2023
88bc175
fix : minor changes
0xsharma Jan 16, 2023
cdee9ff
chg : miner : commitTransactions-stats moved from info to debug
0xsharma Jan 16, 2023
921e428
lint : fix linters
0xsharma Jan 16, 2023
a8139d8
refactor logging
JekaMas Jan 18, 2023
2d11f13
miner : chg : UnauthorizedSignerError to debug
0xsharma Jan 19, 2023
dbcdad5
lint : fix lint
0xsharma Jan 24, 2023
8947e32
fix : log.Logger interface compatibility
0xsharma Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions miner/worker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1012,7 +1012,10 @@ func (w *worker) commitTransactions(env *environment, txs *types.TransactionsByP
// Start executing the transaction
env.state.Prepare(tx.Hash(), env.tcount)

start := time.Now()
var start time.Time
if log.Root().GetHandler().Level() >= log.LvlDebug {
start = time.Now()
Comment thread
0xsharma marked this conversation as resolved.
}

logs, err := w.commitTransaction(env, tx)

Expand All @@ -1037,7 +1040,9 @@ func (w *worker) commitTransactions(env *environment, txs *types.TransactionsByP
coalescedLogs = append(coalescedLogs, logs...)
env.tcount++
txs.Shift()
log.Info("Committed new tx", "tx hash", tx.Hash(), "from", from, "to", tx.To(), "nonce", tx.Nonce(), "gas", tx.Gas(), "gasPrice", tx.GasPrice(), "value", tx.Value(), "time spent", time.Since(start))
if log.Root().GetHandler().Level() >= log.LvlDebug {
log.Debug("Committed new tx", "tx hash", tx.Hash(), "from", from, "to", tx.To(), "nonce", tx.Nonce(), "gas", tx.Gas(), "gasPrice", tx.GasPrice(), "value", tx.Value(), "time spent", time.Since(start))
}

case errors.Is(err, core.ErrTxTypeNotSupported):
// Pop the unsupported transaction without shifting in the next from the account
Expand Down