Skip to content

dev: chg: update PR template to include nodes audience check #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcello33 merged 3 commits into from
Jan 9, 2023
Merged

dev: chg: update PR template to include nodes audience check #641

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b7e808
dev: chg: update PR template to include nodes audience check
marcello33 Dec 21, 2022
c3d8eef
dev: chg: better description
marcello33 Dec 21, 2022
ccdb662
dev: chg: add entry to changes too
marcello33 Dec 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@ Please provide a detailed description of what was done in this PR

Please complete this section if any breaking changes have been made, otherwise delete it

# Nodes audience

Do the features included by this PR must be enabled only for a subset of nodes?
In case, please specify how you handled it (e.g. by adding a flag with a default value...)

Comment thread
marcello33 marked this conversation as resolved.
# Checklist

- [ ] I have added at least 2 reviewer or the whole pos-v1 team
Expand Down Expand Up @@ -41,4 +46,4 @@ Please complete this section with the steps you performed if you ran manual test

# Additional comments

Please post additional comments in this section if you have them, otherwise delete it
Please post additional comments in this section if you have them, otherwise delete it