Skip to content

Shivam/pos 1041#640

Merged
0xsharma merged 5 commits into
developfrom
shivam/POS-1041
Dec 20, 2022
Merged

Shivam/pos 1041#640
0xsharma merged 5 commits into
developfrom
shivam/POS-1041

Conversation

@0xsharma
Copy link
Copy Markdown
Member

In this PR, we add tolerance of multiple keystore files error. Earlier, bor would exit when multiple keystores are found. Now, it can recover from that and will select the correct keystore from multiple files.

@0xsharma 0xsharma requested review from a team, manav2401 and temaniarpit27 December 19, 2022 12:51
Comment thread internal/cli/server/config.go
Comment thread internal/cli/server/config.go Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 20, 2022

Codecov Report

Base: 56.77% // Head: 56.77% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (7b52c93) compared to base (469bd29).
Patch coverage: 66.20% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop     #640    +/-   ##
=========================================
  Coverage    56.77%   56.77%            
=========================================
  Files          607      609     +2     
  Lines        70343    70943   +600     
=========================================
+ Hits         39934    40276   +342     
- Misses       26980    27223   +243     
- Partials      3429     3444    +15     
Impacted Files Coverage Δ
common/math/uint.go 0.00% <0.00%> (ø)
common/time.go 0.00% <0.00%> (ø)
consensus/bor/bor.go 7.64% <0.00%> (ø)
consensus/misc/eip1559.go 48.61% <0.00%> (-38.89%) ⬇️
eth/api_backend.go 0.00% <0.00%> (ø)
eth/bor_checkpoint_verifier.go 8.00% <ø> (ø)
eth/handler.go 54.31% <ø> (ø)
internal/cli/server/config.go 68.61% <0.00%> (-4.43%) ⬇️
core/types/access_list_tx.go 64.91% <19.04%> (-22.90%) ⬇️
miner/worker.go 66.89% <20.45%> (-6.33%) ⬇️
... and 39 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@0xsharma 0xsharma merged commit d8fcda3 into develop Dec 20, 2022
@0xsharma 0xsharma deleted the shivam/POS-1041 branch December 20, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants