Skip to content

Djpolygon/packager dep update#634

Merged
djpolygon merged 1 commit into
qafrom
djpolygon/packagerDepUpdate
Dec 14, 2022
Merged

Djpolygon/packager dep update#634
djpolygon merged 1 commit into
qafrom
djpolygon/packagerDepUpdate

Conversation

@djpolygon
Copy link
Copy Markdown
Contributor

Description

Please provide a detailed description of what was done in this PR

Changes

  • [ x] Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Fixes issue with cross compiling that can occur due to updated binutils in the package repo provided by ubuntu.

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@cffls cffls changed the base branch from develop to qa December 14, 2022 17:14
@djpolygon djpolygon merged commit 5eebbfa into qa Dec 14, 2022
@djpolygon djpolygon deleted the djpolygon/packagerDepUpdate branch December 14, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants