Skip to content

Failing geth integration tests#521

Merged
Raneet10 merged 6 commits into
developfrom
raneet10/pos-618
Sep 27, 2022
Merged

Failing geth integration tests#521
Raneet10 merged 6 commits into
developfrom
raneet10/pos-618

Conversation

@Raneet10
Copy link
Copy Markdown
Contributor

@Raneet10 Raneet10 commented Sep 22, 2022

This PR un-skips a geth integration test and also fixes a minor bug encountered while running the tests. Initially, this PR was meant to trigger CI by "un-skipping" failing integration tests and verify whether these are related to Bor's implementation.

Ref: https://polygon.atlassian.net/browse/POS-618

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 23, 2022

Codecov Report

Base: 56.84% // Head: 56.82% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (2db0dc8) compared to base (2a677a5).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #521      +/-   ##
===========================================
- Coverage    56.84%   56.82%   -0.02%     
===========================================
  Files          607      607              
  Lines        69993    69996       +3     
===========================================
- Hits         39786    39778       -8     
+ Misses       26801    26798       -3     
- Partials      3406     3420      +14     
Impacted Files Coverage Δ
core/state_transition.go 89.10% <ø> (ø)
les/distributor.go 79.68% <0.00%> (-3.13%) ⬇️
rlp/typecache.go 89.53% <0.00%> (-2.33%) ⬇️
les/utils/limiter.go 90.55% <0.00%> (-1.67%) ⬇️
les/vflux/client/serverpool.go 76.76% <0.00%> (-1.66%) ⬇️
consensus/ethash/ethash.go 53.05% <0.00%> (-1.15%) ⬇️
internal/cli/flagset/flagset.go 35.77% <0.00%> (-1.02%) ⬇️
p2p/message.go 51.78% <0.00%> (-0.90%) ⬇️
trie/trie.go 75.73% <0.00%> (-0.74%) ⬇️
eth/filters/api.go 41.13% <0.00%> (-0.71%) ⬇️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Raneet10 Raneet10 changed the title WIP: Failing geth integration tests Failing geth integration tests Sep 27, 2022
@Raneet10 Raneet10 marked this pull request as ready for review September 27, 2022 07:10
@Raneet10 Raneet10 requested a review from a team September 27, 2022 07:37
@Raneet10 Raneet10 merged commit 28b11d1 into develop Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants