Failing geth integration tests#521
Merged
Merged
Conversation
Codecov ReportBase: 56.84% // Head: 56.82% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #521 +/- ##
===========================================
- Coverage 56.84% 56.82% -0.02%
===========================================
Files 607 607
Lines 69993 69996 +3
===========================================
- Hits 39786 39778 -8
+ Misses 26801 26798 -3
- Partials 3406 3420 +14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
marcello33
approved these changes
Sep 27, 2022
temaniarpit27
approved these changes
Sep 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR un-skips a geth integration test and also fixes a minor bug encountered while running the tests. Initially, this PR was meant to trigger CI by "un-skipping" failing integration tests and verify whether these are related to Bor's implementation.
Ref: https://polygon.atlassian.net/browse/POS-618