eth, cli: prevent snap sync mode migration - v0.2.x#495
Merged
manav2401 merged 2 commits intoAug 17, 2022
Conversation
Codecov Report
@@ Coverage Diff @@
## v0.2.17-candidate #495 +/- ##
=====================================================
+ Coverage 56.76% 56.79% +0.03%
=====================================================
Files 578 578
Lines 68317 68307 -10
=====================================================
+ Hits 38778 38795 +17
+ Misses 26182 26166 -16
+ Partials 3357 3346 -11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
pratikspatil024
approved these changes
Aug 17, 2022
JekaMas
approved these changes
Aug 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've seen a couple of scenarios where some of our internal nodes have migrated to snap sync mode. Until we make it working fully, this PR will prevent that from happening.
It adds a preventive layer in the cli (old one) so that it's not enabled through flag and also handles cases where is migrates to snap sync.