Skip to content

internal/cli, cmd/geth: replaced package naoina/toml with BurntSushi/toml and updated config name-tags#486

Merged
pratikspatil024 merged 2 commits into
0xPolygon:developfrom
pratikspatil024:develop
Aug 5, 2022
Merged

internal/cli, cmd/geth: replaced package naoina/toml with BurntSushi/toml and updated config name-tags#486
pratikspatil024 merged 2 commits into
0xPolygon:developfrom
pratikspatil024:develop

Conversation

@pratikspatil024
Copy link
Copy Markdown
Member

This PR,

  • Replaced the naoina/toml package in dumpconfig with BurntSushi/toml package.
  • Updated the toml name tags for the raw field types in the config structure.
  • Updated/modified tests accordingly.
  • Replaced the naoina/toml package in cmd/geth/config.go with BurntSushi/toml package.

Jira Task Link

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 5, 2022

Codecov Report

Merging #486 (154ab4b) into develop (d8d9360) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop     #486   +/-   ##
========================================
  Coverage    57.00%   57.00%           
========================================
  Files          607      607           
  Lines        69907    69899    -8     
========================================
- Hits         39850    39849    -1     
+ Misses       26660    26650   -10     
- Partials      3397     3400    +3     
Impacted Files Coverage Δ
internal/cli/dumpconfig.go 0.00% <0.00%> (ø)
internal/cli/server/config.go 73.61% <ø> (ø)
accounts/keystore/watch.go 90.69% <0.00%> (-4.66%) ⬇️
console/console.go 62.69% <0.00%> (-3.97%) ⬇️
les/utils/exec_queue.go 88.88% <0.00%> (-2.78%) ⬇️
accounts/keystore/account_cache.go 90.20% <0.00%> (-2.10%) ⬇️
core/state/trie_prefetcher.go 78.62% <0.00%> (-1.53%) ⬇️
les/odr.go 89.02% <0.00%> (-1.22%) ⬇️
consensus/ethash/consensus.go 40.21% <0.00%> (-1.07%) ⬇️
p2p/simulations/network.go 57.76% <0.00%> (-0.88%) ⬇️
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pratikspatil024 pratikspatil024 merged commit 16408ba into 0xPolygon:develop Aug 5, 2022
manav2401 pushed a commit to cffls/bor that referenced this pull request Aug 18, 2022
…toml and updated config name-tags (0xPolygon#486)

* removed package naoina/toml from dumpconfig and added BurntSushi/toml

* updated cmd/gethconfig.go
cffls pushed a commit that referenced this pull request Aug 23, 2022
…toml and updated config name-tags (#486)

* removed package naoina/toml from dumpconfig and added BurntSushi/toml

* updated cmd/gethconfig.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants