internal/cli, cmd/geth: replaced package naoina/toml with BurntSushi/toml and updated config name-tags#486
Merged
Conversation
cffls
approved these changes
Aug 5, 2022
manav2401
approved these changes
Aug 5, 2022
Codecov Report
@@ Coverage Diff @@
## develop #486 +/- ##
========================================
Coverage 57.00% 57.00%
========================================
Files 607 607
Lines 69907 69899 -8
========================================
- Hits 39850 39849 -1
+ Misses 26660 26650 -10
- Partials 3397 3400 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
manav2401
pushed a commit
to cffls/bor
that referenced
this pull request
Aug 18, 2022
…toml and updated config name-tags (0xPolygon#486) * removed package naoina/toml from dumpconfig and added BurntSushi/toml * updated cmd/gethconfig.go
cffls
pushed a commit
that referenced
this pull request
Aug 23, 2022
…toml and updated config name-tags (#486) * removed package naoina/toml from dumpconfig and added BurntSushi/toml * updated cmd/gethconfig.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR,
naoina/tomlpackage indumpconfigwithBurntSushi/tomlpackage.naoina/tomlpackage incmd/geth/config.gowithBurntSushi/tomlpackage.Jira Task Link