A thread safe way to take a free port#485
Merged
Merged
Conversation
manav2401
reviewed
Aug 8, 2022
manav2401
reviewed
Aug 8, 2022
manav2401
approved these changes
Aug 16, 2022
marcello33
approved these changes
Aug 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides a common function to find available port during tests and to avoid usage of conflicting ports in tests (which caused a lot of them to fail un-deterministically).
Moreover, to be more deterministic in case of GRPC server, it directly propagates the
net.Listenerobject for port safety.It also adds server options while creating server which is useful for tests.