fix: prevent nil pointer dereference in eth_simulateV1#1993
Closed
harshsingh-cs wants to merge 1 commit into
Closed
fix: prevent nil pointer dereference in eth_simulateV1#1993harshsingh-cs wants to merge 1 commit into
harshsingh-cs wants to merge 1 commit into
Conversation
Add nil checks for BlockOverrides and StateOverrides before accessing their fields in processBlock(). This fixes a crash when eth_simulateV1 is called with minimal parameters that don't include these overrides. The panic occurred at lines 237 and 242 where the code attempted to access nested fields without checking if the parent objects were nil. Fixes #issue (method handler crashed with -32603 error)
|
Member
|
Hey, this is already merged via this #1955. Closing this as a dup. Thanks for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Add nil checks for
BlockOverridesandStateOverridesbefore accessing their fields inprocessBlock(). This fixes a crash wheneth_simulateV1is called with minimal parameters that don't include these overrides.The panic occurred at lines 237 and 242 where the code attempted to access nested fields without checking if the parent objects were nil.
Here is how we can reproduce
Description
Please provide a detailed description of what was done in this PR
Changes
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Nodes audience
In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)
Checklist
Cross repository changes
Testing
Manual tests
Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it