Skip to content

Include missing check of P256 on Amoy #1877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucca30 merged 2 commits into from
Nov 13, 2025
Merged

Include missing check of P256 on Amoy #1877

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6dc30f5
checks p256 instruction
lucca30 Nov 13, 2025
e27c091
lint fix
lucca30 Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions core/vm/contracts_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,19 +439,22 @@ func TestPrecompiledP256Verify(t *testing.T) {
// BOR: if this test failed, it means you should include PrecompiledP256Verify in the PrecompiledContracts
// TODO: handle when common.BytesToAddress([]byte{0x01, 0x00}) will colide a new Ethereum's precompile
func TestPrecompiledP256VerifyAlwaysAvailableInHFs(t *testing.T) {
Comment thread
lucca30 marked this conversation as resolved.
latestHfRules := params.BorMainnetChainConfig.Rules(big.NewInt(math.MaxInt64), true, 0)
precompiledP256VerifyAddress := common.BytesToAddress([]byte{0x01, 0x00})

addresses := ActivePrecompiles(latestHfRules)
addressFound := false
for _, addr := range addresses {
if addr == precompiledP256VerifyAddress {
addressFound = true
break
chainConfigs := []*params.ChainConfig{params.BorMainnetChainConfig, params.AmoyChainConfig}
for _, chainConfig := range chainConfigs {
latestHfRules := chainConfig.Rules(big.NewInt(math.MaxInt64), true, 0)
precompiledP256VerifyAddress := common.BytesToAddress([]byte{0x01, 0x00})

addresses := ActivePrecompiles(latestHfRules)
addressFound := false
for _, addr := range addresses {
if addr == precompiledP256VerifyAddress {
addressFound = true
break
}
}
}
assert.Equal(t, true, addressFound)
assert.Equal(t, true, addressFound)

preCompiledContracts := ActivePrecompiledContracts(latestHfRules)
assert.Equal(t, &p256Verify{}, preCompiledContracts[precompiledP256VerifyAddress])
preCompiledContracts := ActivePrecompiledContracts(latestHfRules)
assert.Equal(t, &p256Verify{}, preCompiledContracts[precompiledP256VerifyAddress])
}
}
Loading