Skip to content

ssTxs: fix receiptsHash mismatch #1829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucca30 merged 3 commits into from
Oct 17, 2025
Merged

ssTxs: fix receiptsHash mismatch #1829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a1d3828
ssTxs: fix receiptsHash mismatch
kamuikatsurgi Oct 17, 2025
8364788
chore: remove block hash and number
kamuikatsurgi Oct 17, 2025
936acf9
revert: add block number
kamuikatsurgi Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions consensus/bor/bor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1071,17 +1071,25 @@ func insertStateSyncTransactionAndCalculateReceipt(stateSyncData []*types.StateS
logsFromReceiptCount := countLogsFromReceipts(receipts)
stateSyncLogs := allLogs[logsFromReceiptCount:]

txIndex := uint(len(body.Transactions) - 1)
for _, l := range stateSyncLogs {
l.TxIndex = txIndex
}

stateSyncReceipt := &types.Receipt{
// Consensus fields
Type: types.StateSyncTxType,
PostState: header.Root.Bytes(),
Status: types.ReceiptStatusSuccessful,
CumulativeGasUsed: header.GasUsed,
TxHash: stateSyncTx.Hash(),
Logs: stateSyncLogs,
BlockNumber: header.Number,
TransactionIndex: uint(len(body.Transactions)), // we already appended state sync tx on body
EffectiveGasPrice: big.NewInt(0),
// Implementation fields
TxHash: stateSyncTx.Hash(),
GasUsed: 0,
// Inclusion information
BlockNumber: header.Number,
TransactionIndex: txIndex,
}

stateSyncReceipt.Bloom = types.CreateBloom(stateSyncReceipt)
receipts = append(receipts, stateSyncReceipt)

Expand Down
4 changes: 2 additions & 2 deletions core/types/receipt.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ func (r *Receipt) decodeTyped(b []byte) error {
}

switch b[0] {
case DynamicFeeTxType, AccessListTxType, BlobTxType, SetCodeTxType:
case DynamicFeeTxType, AccessListTxType, BlobTxType, SetCodeTxType, StateSyncTxType:
var data receiptRLP

err := rlp.DecodeBytes(b[1:], &data)
Expand Down Expand Up @@ -394,7 +394,7 @@ func (rs Receipts) EncodeIndex(i int, w *bytes.Buffer) {
}
w.WriteByte(r.Type)
switch r.Type {
case AccessListTxType, DynamicFeeTxType, BlobTxType, SetCodeTxType:
case AccessListTxType, DynamicFeeTxType, BlobTxType, SetCodeTxType, StateSyncTxType:
rlp.Encode(w, data)
default:
// For unsupported types, write nothing. Since this is for
Expand Down
Loading