Consistent visibility modifiers in OpenAI #694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-mo-143
requested changes
Aug 12, 2025
Contributor
joshua-mo-143
left a comment
joshua-mo-143
left a comment
There was a problem hiding this comment.
Please add methods for these rather than directly making them pub. It will help with ensuring that we are not constantly adding breaking changes to the library by adding new public fields.
Contributor
|
Hi, thanks for the PR! Just reviewed. |
joshua-mo-143
approved these changes
Aug 12, 2025
Contributor
joshua-mo-143
left a comment
joshua-mo-143
left a comment
There was a problem hiding this comment.
actually, LGTM - if the breaking changes for the integration are really that much of an issue that we need accessor patterns we'll just do it in a separate ticket as it will need to probably affect the entire module/integration
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some OpenAI completion types are inconsistently private, I need them public so that I can convert them into OpenAPI generated types