Skip to content

bug(rig-791): documents not consistently added to DeepSeek prompts #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2025
Merged

bug(rig-791): documents not consistently added to DeepSeek prompts #528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
378c133
fix(rig-791): documents not added consistently to user prompts
joshua-mo-143 Jun 22, 2025
94ceb05
refactor: amendments
joshua-mo-143 Jun 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ target/
.idea/
.vscode/
.devcontainer/
.fastembed_cache/

# env
.env
Expand Down
11 changes: 11 additions & 0 deletions rig-core/src/providers/deepseek.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

use crate::client::{CompletionClient, ProviderClient};
use crate::json_utils::merge;
use crate::message::Document;
use crate::providers::openai;
use crate::providers::openai::send_compatible_streaming_request;
use crate::streaming::StreamingCompletionResponse;
Expand Down Expand Up @@ -236,6 +237,12 @@ impl TryFrom<message::Message> for Vec<Message> {
content: text.text,
name: None,
}),
message::UserContent::Document(Document { data, .. }) => {
Some(Message::User {
content: data,
name: None,
})
}
_ => None,
})
.collect::<Vec<_>>();
Expand Down Expand Up @@ -391,9 +398,11 @@ impl DeepSeekCompletionModel {
) -> Result<serde_json::Value, CompletionError> {
// Build up the order of messages (context, chat_history, prompt)
let mut partial_history = vec![];

if let Some(docs) = completion_request.normalized_documents() {
partial_history.push(docs);
}

partial_history.extend(completion_request.chat_history);

// Initialize full history with preamble (or empty if non-existent)
Expand Down Expand Up @@ -452,6 +461,8 @@ impl CompletionModel for DeepSeekCompletionModel {
> {
let request = self.create_completion_request(completion_request)?;

tracing::debug!("DeepSeek completion request: {request:?}");

let response = self
.client
.post("/chat/completions")
Expand Down