Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move context documents to user prompt message #43

Merged
merged 3 commits into from
Oct 1, 2024
Merged

fix: move context documents to user prompt message #43

merged 3 commits into from
Oct 1, 2024

Conversation

0xMochan
Copy link
Contributor

@0xMochan 0xMochan commented Oct 1, 2024

Context documents get prepended to the prompt user message rather than to system messages.

cvauclair
cvauclair requested changes Oct 1, 2024
View reviewed changes
rig-core/src/completion.rs Show resolved Hide resolved
rig-core/src/providers/perplexity.rs Outdated Show resolved Hide resolved
cvauclair
cvauclair requested changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@cvauclair cvauclair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just need to fix one of the tests

rig-core/src/completion.rs Show resolved Hide resolved
@cvauclair cvauclair merged commit 78ec4cb into main Oct 1, 2024
2 checks passed
@github-actions github-actions bot mentioned this pull request Oct 1, 2024
Merged
@0xMochan 0xMochan deleted the fix/context-documents branch November 22, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvauclair cvauclair cvauclair approved these changes

@marieaurore123 marieaurore123 Awaiting requested review from marieaurore123

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xMochan @cvauclair