other: Code refactoring for LoggingService.cs #1217
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code refactoring for LoggingService.cs
PR Type
What kind of change does this PR introduce?
other: Code refactoring for LoggingService.cs
Other information
I've refactored the code to make it more readable, maintainable.
Changes:
MessageFormat
constant toMessageFormatString
to make its purpose clearer.timeStamp
for theDateTime.UtcNow.ToString(CultureInfo.InvariantCulture)
to make the code more readable.WriteLogMessages()
method was extracted from theInitializeLogFileWriterBackgroundTaskAsync()
method to separate the responsibility of continuously writing the log messages from the initialization process. By doing so, the code is more readable, maintainable, and adheres to the Single Responsibility Principle.