Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace LogFunc with the standard slog.Logger #113

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Replace LogFunc with the standard slog.Logger #113

merged 1 commit into from
Nov 14, 2024

Conversation

akarl
Copy link
Collaborator

@akarl akarl commented Nov 8, 2024

No description provided.

logging_test.go Outdated Show resolved Hide resolved
server.go Outdated Show resolved Hide resolved
@akarl akarl marked this pull request as ready for review November 13, 2024 08:50
@akarl akarl requested a review from bombsimon November 13, 2024 08:50
Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some thoughts around attributes. Approving now to unblock since I'm slow reviewing these PRs.

client.go Outdated Show resolved Hide resolved
client.go Outdated Show resolved Hide resolved
logging.go Show resolved Hide resolved
client.go Outdated Show resolved Hide resolved
@akarl akarl force-pushed the slog branch 4 times, most recently from af47449 to 8743706 Compare November 14, 2024 13:14
@akarl akarl merged commit d5524a5 into master Nov 14, 2024
2 checks passed
@akarl akarl deleted the slog branch November 14, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants