Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PreCamCS #164

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

PreCamCS #164

wants to merge 5 commits into from

Conversation

KcRobin9
Copy link
Collaborator

@KcRobin9 KcRobin9 commented Jun 4, 2024

(wip)

@KcRobin9 KcRobin9 requested a review from 0x1F9F1 June 22, 2024 23:22
Copy link
Contributor

@sharkwouter sharkwouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested it and it does not seem to cause any crashes. I assumed it did something with the camera, which works fine. I'm no entirely sure where which function is used, though. It seems PreCamCS::Init and PreCamCS::Reset are called on the loading screen. I don't know when the PreCamCs::Update and PreCamCs::MakeActive are used. While testing I added some breakpoints and the ones for Update and MakeActive did not seem to trigger while playing.

@sharkwouter
Copy link
Contributor

I see no difference between master and this branch when entering a level either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants