Skip to content

Commit

Permalink
ipc-sem-rework-task-wakeups-checkpatch-fixes
Browse files Browse the repository at this point in the history
WARNING: line over 80 characters
torvalds#241: FILE: ipc/sem.c:815:
+				semop_completed |= wake_const_ops(sma, num, wake_q);

WARNING: line over 80 characters
torvalds#250: FILE: ipc/sem.c:826:
+				semop_completed |= wake_const_ops(sma, i, wake_q);

WARNING: line over 80 characters
torvalds#282: FILE: ipc/sem.c:857:
+static int update_queue(struct sem_array *sma, int semnum, struct wake_q_head *wake_q)

WARNING: line over 80 characters
torvalds#344: FILE: ipc/sem.c:973:
+							      sops[i].sem_num, wake_q);

WARNING: Missing a blank line after declarations
torvalds#405: FILE: ipc/sem.c:1242:
+	int err, val;
+	WAKE_Q(wake_q);

WARNING: line over 80 characters
torvalds#570: FILE: ipc/sem.c:1920:
+	 * We _do_ care, nonetheless, about being awoken by a signal or spuriously.

total: 0 errors, 6 warnings, 567 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

./patches/ipc-sem-rework-task-wakeups.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Davidlohr Bueso <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
  • Loading branch information
akpm00 authored and hnaz committed Dec 7, 2016
1 parent d145850 commit deac8be
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions ipc/sem.c
Original file line number Diff line number Diff line change
Expand Up @@ -1917,10 +1917,11 @@ SYSCALL_DEFINE4(semtimedop, int, semid, struct sembuf __user *, tsops,
* fastpath: the semop has completed, either successfully or not, from
* the syscall pov, is quite irrelevant to us at this point; we're done.
*
* We _do_ care, nonetheless, about being awoken by a signal or spuriously.
* The queue.status is checked again in the slowpath (aka after taking
* sem_lock), such that we can detect scenarios where we were awakened
* externally, during the window between wake_q_add() and wake_up_q().
* We _do_ care, nonetheless, about being awoken by a signal or
* spuriously. The queue.status is checked again in the slowpath (aka
* after taking sem_lock), such that we can detect scenarios where we
* were awakened externally, during the window between wake_q_add() and
* wake_up_q().
*/
error = READ_ONCE(queue.status);
if (error != -EINTR) {
Expand Down

0 comments on commit deac8be

Please sign in to comment.