Open
Conversation
…code - Fix 1: Cap carry buffer at MAX_TAG*2 to prevent unbounded growth when '>' never arrives for a prefix tag like <function=...>. - Fix 2: Strip partial prefix tags (<function=name, <parameter=name) at end of stream in flush() using regex anchored to $. - Fix 3: Move `import re` to module level, remove inline imports. - Fix 4: Remove dead `_implicit_think` attribute from Router.__init__(). - Fix 5: Add IN_PARAMETER state so standalone <parameter=name> closes on </parameter> instead of swallowing text until </function>. - Fix 6: Add comment explaining why start_in_thinking=True is correct for current models (Qwen3/3.5 chat templates inject <think>). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the 6 review fixes requested by @waybarrios on waybarrios#132:
MAX_TAG * 2to prevent unbounded growth when>never arrives for a prefix tag like<function=...><function=name,<parameter=name) at end of stream inflush()using$-anchored regeximport reto module level, remove both inline imports fromflush()methods_implicit_thinkattribute from_AnthropicStreamRouter.__init__()IN_PARAMETERstate so standalone<parameter=name>closes on</parameter>instead of swallowing text until</function>start_in_thinking=Trueis correct for current models (Qwen3/3.5 chat templates inject<think>)Test plan
pytest tests/test_anthropic_stream_scrubber.py -v)<parameter=...>, dead code removalblackformatting verified🤖 Generated with Claude Code