Made the AppImage updatable & get rid of libfuse2 dependency #36
Conversation
|
@andy5995 where is placed appimagetool? you need at least to move it into the working directory |
make-appimage.sh
Outdated
| [ -z "$GITHUB_REPOSITORY_OWNER" ] && GITHUB_REPOSITORY_OWNER="0ad-matters" | ||
| UPINFO="gh-releases-zsync|$GITHUB_REPOSITORY_OWNER|$REPO|$TAG|*$ARCH.AppImage.zsync" | ||
|
|
||
| ./appimagetool --appimage-extract-and-run \ |
There was a problem hiding this comment.
| ./appimagetool --appimage-extract-and-run \ | |
| appimagetool --appimage-extract-and-run \ |
It's in the PATH, installed to $HOME/.local/bin https://github.com/andy5995/linuxdeploy-build-helper-container/blob/3f70f7b215753306b9474f3d95c777498a0c7186/Dockerfile#L99
There was a problem hiding this comment.
Hmmm... failed. Strange that this option isn't available:
2025-02-01T01:46:41.2132353Z appimagetool --appimage-extract-and-run \
2025-02-01T01:46:41.2132703Z --comp zstd --mksquashfs-opt -Xcompression-level --mksquashfs-opt 20 \
2025-02-01T01:46:41.2133014Z -u "$UPINFO" \
2025-02-01T01:46:41.2133177Z "$APPDIR" "$OUT_APPIMAGE"
2025-02-01T01:46:41.2183371Z Option parsing failed: Unknown option --appimage-extract-and-run
2025-02-01T01:46:42.4148172Z ##[error]Process completed with exit code 1.
I'm installing it in the docker image from https://github.com/AppImage/appimagetool
Could we just run that argument from the appimage first?
[andy@prometheus Downloads]$ ./0ad-0.27.0-2501310402-x86_64.AppImage --appimage-help
AppImage options:
--appimage-extract [<pattern>] Extract content from embedded filesystem image
If pattern is passed, only extract matching
files
--appimage-extract-and-run Temporarily extract content from embedded
filesystem image, run contained application,
then delete temporarily extracted content
--appimage-help Print this help
--appimage-mount Mount embedded filesystem image and print
mount point and wait for kill with Ctrl-C
--appimage-offset Print byte offset to start of embedded
filesystem image
--appimage-portable-home Create a portable home folder to use as $HOME
--appimage-portable-config Create a portable config folder to use as
$XDG_CONFIG_HOME
--appimage-signature Print digital signature embedded in AppImage
--appimage-updateinfo[rmation] Print update info embedded in AppImage
--appimage-version Print version of AppImage runtime
There was a problem hiding this comment.
that argument is used widelly in systems without a working FUSE, such as a docker container... I added that flag because before the command was a local file and worked. In this case, we should not need to extract and run the AppImage from $PATH
|
@andy5995 should I set GITHUB_REPOSITORY_OWNER as ivan-hc to see if update via |
|
@ivan-hc I don't think that will be necessary but thanks for the offer. I know you already did a bit of testing on your fork. I'll merge this as-is and we'll continue from there. |
| @@ -45,6 +45,7 @@ sudo DEBIAN_FRONTEND=noninteractive -i sh -c "apt update && apt -y upgrade && \ | |||
| cmake \ | |||
| curl \ | |||
| $CC \ | |||
| desktop-file-utils \ | |||
There was a problem hiding this comment.
@ivan-hc Why is this needed now?
There was a problem hiding this comment.
Sometime appimagetool require to check if the .desktop file has valid entries, if not to bundle the AppImage fails.
I don't know you, but in my experience I had long workflows failed at the last moment because appigetool was looking for desktop-file-validate in $PATH, so from then I always added this in all my projects.
There was a problem hiding this comment.
Then it sounds like this would be another package that should be added to the linuxdeploy image.
There was a problem hiding this comment.
There was a problem hiding this comment.
fix #33
fix #9
@andy5995 note that the last workflow has failed, since I removed the re-downloaded appimagetool
You need to redirect the ./appimagetool reference to the right path or this would not work.
Thanks for your attention.