-
Couldn't load subscription status.
- Fork 112
Genesis v6 from JSON v5 export and v5 JSON export #1212
Conversation
… data from snapshot)
…ner" in fn recovery_owners_operators
…ob from JSON file with accounts)
|
Two questions spring to mind on this set of changes:
|
This is legacy from FB. It's a real PITA but many of the tests and builds depend on finding these files. Not something that can be easily fixed, we've tried a number of things.
@simsekgokhan is good about testing, so I'm guessing it's just not documented. Otherwise we need to ticket the e2e tests for this. Edit: I see the steps to reproduce are here in the PR text. We likely just need to create some fixtures out of this and add the test. |
|
This PR looks correct to me. Although we are missing e2e tests for this feature. Ordinarily we wouldn't merge this, but since we need to do cleaning up on the v6 branches I'll approve for merge. IBut I see the steps to reproduce in the PR text. We need to clean up branches so, it's approved assuming we add the task for the e2e test.w |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK if we add tests
|
LGTM |
This PR covers two related/dependent features seen below as Step 1, 2 and fixes for some Move errors (see commits).
Steps:
v5 JSON export (new feature)
cargo r -p ol-genesis-tools -- --recover /opt/rec.json --snapshot-path /opt/state_ver*state_ver: https://github.com/OLSF/epoch-archive/tree/main/359/state_ver_76353076.a0ff
Resulting rec.json: https://drive.google.com/file/d/1jaumaKdaGjWExNdUVqNZDvIAQPmppt19/view
Genesis v6 from JSON v5 (new feature)
Create genesis blob using v6 code from JSON v5 export:
cargo r -p ol-genesis-tools -- --fork --recovery-json-path /opt/rec.json --output-path /opt/genesis_from_recovery.blobResulting genesis_from_recovery.blob: https://drive.google.com/file/d/1f2gfISy5AecZIXGQEOgP4yQm3ArpYRO1/view?usp=sharing
Verify the validity of genesis blob by starting a v6 node in test mode with it:
cargo r -p diem-node -- --test --genesis-modules /opt/genesis_from_recovery.blobValidator logs: https://drive.google.com/file/d/1DCuKe4hY0VwzYS3nMsQie4o5uyt25coo/view?usp=sharing