app.go and module manager clean up #1
Conversation
- leave some TODOs
| @@ -897,57 +921,6 @@ func initParamsKeeper(appCodec codec.BinaryCodec, legacyAmino *codec.LegacyAmino | |||
| return paramsKeeper | |||
| } | |||
|
|
|||
| func (app *App) InitializeAppVersion(ctx sdk.Context) { | |||
There was a problem hiding this comment.
This seems redundant in 0.52 since AppVersion in BaseApp passes directly through to the consensus keeper.
| } | ||
| } | ||
|
|
||
| // OfferSnapshot is a wrapper around the baseapp's OfferSnapshot method. It is |
There was a problem hiding this comment.
This seems redundant in 0.52 since there's no way to obtain the AppVersion from an abci.RequestOfferSnapshot. Not totally clear why it is needed to lazy mount stores, or offer snapshots for an arbitrary consensus version (maybe for syncing?) but if it is we'll need a workaround. Maybe a custom request type is needed?
app/check_tx.go
Outdated
There was a problem hiding this comment.
Maybe in a follow-up this should be a sdk.CheckTxHandler?
There was a problem hiding this comment.
That makes sense to me
There was a problem hiding this comment.
any reason we cannot use the sdk manager?
There was a problem hiding this comment.
I had the same thought, but this manager is doing something fundamentally different with keeping around sets of versioned modules. I haven't audited the code paths to enough to determine if there could be a map[uint64]sdk.ModuleManger, but maybe worth investigation into a refactoring clean up
The module manager work with configurator and upgrades was a little tricky.
RegisterServicestoConfigurator, satisfying 0.52 interface. IncludeacceptedMessageslogic.