Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EXTERNAL] Update docs blockchain/time-is-money #2768

Closed
wants to merge 1 commit into from

Conversation

abdotop
Copy link

@abdotop abdotop commented Oct 10, 2024

I'd like to report an inconsistency in the project requirements and test implementation:

The README instructions state:
"Add a function addPayedArtist() that takes as parameters a string and an address to register an artist to the festival."

However, the tests are only using the address parameter and not the name (string) parameter when calling this function.

This discrepancy is causing confusion and leading to implementation errors. It would be helpful to either:

  1. Update the tests to include both the name and address parameters, or
  2. Modify the README to reflect that only the address is required for the addPayedArtist() function.

Clarifying this point will ensure that the implementation matches the intended requirements and resolves the current test failures.

I'd like to report an inconsistency in the project requirements and test implementation:

The README instructions state:
"Add a function addPayedArtist() that takes as parameters a string and an address to register an artist to the festival."

However, the tests are only using the address parameter and not the name (string) parameter when calling this function.

This discrepancy is causing confusion and leading to implementation errors. It would be helpful to either:
1. Update the tests to include both the name and address parameters, or
2. Modify the README to reflect that only the address is required for the addPayedArtist() function.

Clarifying this point will ensure that the implementation matches the intended requirements and resolves the current test failures.
@HarryVasanth HarryVasanth changed the title Update README.md [EXTERNAL] Update README.md Oct 18, 2024
@HarryVasanth HarryVasanth changed the title [EXTERNAL] Update README.md [EXTERNAL] Update docs blockchain/time-is-money Oct 18, 2024
@abdotop abdotop closed this by deleting the head repository Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant