Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EXTERNAL] Fix small typos sortable #2767

Merged
merged 3 commits into from
Oct 30, 2024
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions subjects/sortable/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@ You must write all of the code from scratch. You are not allowed to rely on any

#### Fetching the data
In order to get the information, you should use `fetch`.
When you use `fetch` in JS, it always returns a `Promise`. We will look more deeply into that later on. For now, tak a look at this:
When you use `fetch` in JS, it always returns a `Promise`. We will look more deeply into that later on. For now, take a look at this:

```js
// This function is called only after the data has been fetched, and parsed.
const loadData = heroes => {
console.log(heroes)
}

// Request the file with fetch, the data will downloaded to your browser cache.
// Request the file with fetch, and the data will be downloaded to your browser cache.
fetch('https://rawcdn.githack.com/akabab/superhero-api/0.2.0/api/all.json')
.then((response) => response.json()) // parse the response from JSON
.then(loadData) // .then will call the `loadData` function with the JSON value.
Expand Down
Loading