Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CON-3133 Fix AI/emotions detector #2710

Merged
merged 6 commits into from
Sep 6, 2024
Merged

CON-3133 Fix AI/emotions detector #2710

merged 6 commits into from
Sep 6, 2024

Conversation

Oumaimafisaoui
Copy link
Contributor

@Oumaimafisaoui Oumaimafisaoui commented Sep 2, 2024 •
edited
Loading

Resolves: CON-3133

  • Update train.py to save learning curves and model architecture
  • Modify predict.py to evaluate on test set instead of validation set
  • Ensure 62% accuracy requirement on test set

@Oumaimafisaoui Oumaimafisaoui added the 🗂️ docs Documentation label Sep 2, 2024
@Oumaimafisaoui Oumaimafisaoui self-assigned this Sep 2, 2024
@Oumaimafisaoui Oumaimafisaoui added the 🤸 skip-check-links Skip check links label Sep 2, 2024
@Oumaimafisaoui Oumaimafisaoui changed the title Chore(AI): Fix emotions detector CON-3133 Fix AI/emotions detector Sep 2, 2024
MSilva95
MSilva95 requested changes Sep 3, 2024
View reviewed changes
Copy link
Member

@MSilva95 MSilva95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small change

subjects/ai/emotions-detector/README.md Outdated Show resolved Hide resolved
@HarryVasanth HarryVasanth added the 📕 AI Artificial Intelligence label Sep 4, 2024
MSilva95
MSilva95 approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@MSilva95 MSilva95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Oumaimafisaoui Oumaimafisaoui merged commit 1d34ea0 into master Sep 6, 2024
3 checks passed
@Oumaimafisaoui Oumaimafisaoui deleted the CON-3133-Fixing-Emotions-detector-project branch September 6, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSilva95 MSilva95 MSilva95 approved these changes

Assignees

@Oumaimafisaoui Oumaimafisaoui

Labels
📕 AI Artificial Intelligence 🗂️ docs Documentation 🤸 skip-check-links Skip check links
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Oumaimafisaoui @MSilva95 @HarryVasanth