Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CON-3132 Remake the inspector-image project (part1) #2708

Merged
merged 2 commits into from
Sep 22, 2024

Conversation

zamazzal
Copy link
Contributor

@zamazzal zamazzal commented Sep 1, 2024

CON-3132

Why?

The image-inspector is not a suitable name and it should be image-inspector.
The current project is not compatible with the 01 subjects format and quality.

Solution Overview

A new folder was added with the correct name and we decided not to remove the old one to avoid impacting the schools.
The project format and quality are improved to meet the requirements.

@zamazzal zamazzal added the 🗂️ docs Documentation label Sep 1, 2024
@zamazzal zamazzal self-assigned this Sep 1, 2024
@zamazzal zamazzal requested a review from zanninso September 1, 2024 18:07
Copy link
Contributor

@zanninso zanninso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left few comments.

subjects/cybersecurity/image-inspector/README.md Outdated Show resolved Hide resolved
subjects/cybersecurity/image-inspector/README.md Outdated Show resolved Hide resolved
subjects/cybersecurity/image-inspector/README.md Outdated Show resolved Hide resolved
subjects/cybersecurity/image-inspector/audit/README.md Outdated Show resolved Hide resolved
@Oumaimafisaoui Oumaimafisaoui added the 📕 Cyber Security Cybersecurity label Sep 5, 2024
@HarryVasanth HarryVasanth changed the title CON-3132-remake-the-inspector-image-project CON-3132 Remake the inspector-image project Sep 15, 2024
Copy link
Contributor

@zanninso zanninso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments.

@zamazzal zamazzal merged commit 9b8c587 into master Sep 22, 2024
1 of 3 checks passed
@zamazzal zamazzal deleted the CON-3132-remake-the-inspector-image-project branch September 22, 2024 15:34
@zamazzal zamazzal restored the CON-3132-remake-the-inspector-image-project branch September 23, 2024 08:07
@zamazzal zamazzal changed the title CON-3132 Remake the inspector-image project CON-3132 Remake the inspector-image project (part1) Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📕 Cyber Security Cybersecurity 🗂️ docs Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants