Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CON-2931 Resolve missing assets for stealth-boom project #2705

Conversation

EldritchGriffin
Copy link
Contributor

@EldritchGriffin EldritchGriffin commented Aug 29, 2024

CON-2931

Refined the subject and audit of the stealth-boom project and provided a file that contains the basic assets required for the project

@EldritchGriffin EldritchGriffin added the 🗂️ docs Documentation label Aug 29, 2024
@EldritchGriffin EldritchGriffin self-assigned this Aug 29, 2024
@Oumaimafisaoui Oumaimafisaoui linked an issue Aug 29, 2024 that may be closed by this pull request
@EldritchGriffin EldritchGriffin added the 🤸 skip-check-links Skip check links label Aug 29, 2024
@HarryVasanth HarryVasanth changed the title CON-2931-Resolve-missing-assets-for-stealth-boom-project CON-2931 Resolve missing assets for stealth-boom project Aug 30, 2024
@Oumaimafisaoui Oumaimafisaoui added the 📕 Game Dev Game Development label Aug 30, 2024
@Oumaimafisaoui Oumaimafisaoui requested review from MSilva95 and removed request for zanninso August 30, 2024 14:43
@Oumaimafisaoui Oumaimafisaoui removed their request for review September 2, 2024 13:41
Copy link
Member

@MSilva95 MSilva95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it's good, I made some suggestions and there were some things missing, some contradictions, but mostly it's grammar suggestions and improve questions order.

subjects/gaming/stealth-boom/README.md Outdated Show resolved Hide resolved
subjects/gaming/stealth-boom/audit/README.md Outdated Show resolved Hide resolved
subjects/gaming/stealth-boom/audit/README.md Outdated Show resolved Hide resolved
subjects/gaming/stealth-boom/audit/README.md Outdated Show resolved Hide resolved
subjects/gaming/stealth-boom/audit/README.md Show resolved Hide resolved
subjects/gaming/stealth-boom/README.md Outdated Show resolved Hide resolved
subjects/gaming/stealth-boom/audit/README.md Outdated Show resolved Hide resolved
subjects/gaming/stealth-boom/audit/README.md Outdated Show resolved Hide resolved
subjects/gaming/stealth-boom/README.md Outdated Show resolved Hide resolved
subjects/gaming/stealth-boom/audit/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Oumaimafisaoui Oumaimafisaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issues, LGTM 🚀

Copy link
Contributor

@Oumaimafisaoui Oumaimafisaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@MSilva95 MSilva95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EldritchGriffin EldritchGriffin merged commit b0d0417 into master Sep 4, 2024
3 checks passed
@EldritchGriffin EldritchGriffin deleted the CON-2931-Resolve-missing-assets-for-stealth-boom-project branch September 4, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗂️ docs Documentation 📕 Game Dev Game Development 🤸 skip-check-links Skip check links
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DUPLICATE][BUG] Issue stealth-boom subject [BUG] Issue in the stealth-boom gaming project
3 participants