-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CON-3045 Tests(DPxAI): Upload test for quest01 objects-around #2679
CON-3045 Tests(DPxAI): Upload test for quest01 objects-around #2679
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the new naming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests fail the provided solution here 01-edu/solutions#50 (even after the suggested change)
variable myRobot is declared and of type object: PASS
property name from myRobot is of type string: PASS
property age from myRobot is of type number: PASS
property hasEnergy from myRobot is of type boolean: PASS
all 3 variable should be defined and have the right values: FAIL
======= Error ======
-> Expected values to be strictly deep-equal:
+ actual - expected
{
+ age: 5,
+ hasEnergy: true,
+ name: 'RoboMax'
- age: 27,
- hasEnergy: false,
- name: 'Freddy'
}
======= Code =======
// Provided setup
let robot = {
name: 'Freddy',
age: 27,
hasEnergy: false,
}
// Your code
let myRobot = {
name: 'RoboMax',
age: 5,
hasEnergy: true,
}
let name = myRobot.name
let age = myRobot.age
let hasEnergy = myRobot.hasEnergy;
// The tests
equal({ name, age, hasEnergy }, robot);
@nprimo the solution PR is not updated yet, i will push a commit with the correct version exemple of the code i'll push to the solution file :
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
https://01talent.atlassian.net/browse/CON-3045