Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CON-3007 Tests(DPxAI): Add test for Quest01 play-with-variables #2672

Merged
merged 4 commits into from
Aug 30, 2024

Conversation

lotoussa
Copy link
Contributor

@lotoussa lotoussa commented Jul 31, 2024

@lotoussa lotoussa added the 🧪 test Tests label Jul 31, 2024
@lotoussa lotoussa requested a review from nprimo July 31, 2024 13:54
@lotoussa lotoussa self-assigned this Jul 31, 2024
@HarryVasanth HarryVasanth changed the title Tests(DPxAI): Add test for Quest01 play-with-variables CON-3007 Tests(DPxAI): Add test for Quest01 play-with-variables Jul 31, 2024
Copy link
Contributor

@nprimo nprimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test fails with the solution in 01-edu/solutions#46 wit the following output

escapeFromDelimiters is declared and includes a double-quote: FAIL

======= Error ======
 -> power is not defined


======= Code =======
// Your code
let escapeFromDelimiters = "This is an example of all three quotes: \`, \", and \'"
let escapeTheEscape = "This is an example of a backslash: \\"
power = "levelMax";

// The tests
if (typeof escapeFromDelimiters === 'undefined') {
  throw Error(
    `You didn't even define the variable... we've been through this already !`,
  )
}

if (!escapeFromDelimiters.includes('"')) {
  throw Error('escapeFromDelimiters must include a double-quote"')
};

js/tests/play-with-variables_test.json Outdated Show resolved Hide resolved
@nprimo
Copy link
Contributor

nprimo commented Aug 7, 2024

@lotoussa the current tests are failing the current solution here 01-edu/solutions#48

@lotoussa lotoussa requested a review from nprimo August 7, 2024 23:01
@Oumaimafisaoui Oumaimafisaoui self-requested a review August 30, 2024 13:02
Copy link
Contributor

@Oumaimafisaoui Oumaimafisaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Oumaimafisaoui Oumaimafisaoui merged commit a7b2fc4 into master Aug 30, 2024
3 checks passed
@Oumaimafisaoui Oumaimafisaoui deleted the CON-3007-test-quest-01-ex-01 branch August 30, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants