Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CON-3011 Tests(DPxAI): Add test for Quest01 the-smooth-operator #2671

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

lotoussa
Copy link
Contributor

@lotoussa lotoussa commented Jul 31, 2024

@lotoussa lotoussa added the 🧪 test Tests label Jul 31, 2024
@lotoussa lotoussa requested a review from nprimo July 31, 2024 13:37
@lotoussa lotoussa self-assigned this Jul 31, 2024
@HarryVasanth HarryVasanth changed the title Tests(DPxAI): Add test for Quest01 the-smooth-operator CON-3011 Tests(DPxAI): Add test for Quest01 the-smooth-operator Jul 31, 2024
js/tests/the-smooth-operator_test.json Outdated Show resolved Hide resolved
@nprimo
Copy link
Contributor

nprimo commented Aug 7, 2024

The tests fail the solution in the PR 01-edu/solutions#49

values of the variable are a result of the operations on the variable smooth ( 10 ): FAIL

======= Error ======
 -> age is not defined


======= Code =======
// Provided setup
let smooth = 10

// Your code
let lessSmooth = smooth-1
let semiSmooth = smooth/2
let plus11 =  smooth +11
let ultraSmooth =  smooth**2

let presentation= `Hello, my name is ${name} and I'm ${age} years old`;

// The tests
equal(lessSmooth, 9)
equal(semiSmooth, 5)
equal(plus11, 21);

@lotoussa lotoussa requested a review from nprimo August 7, 2024 21:41
Copy link
Contributor

@nprimo nprimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Wait for #2666 to be approved before merging

@Oumaimafisaoui Oumaimafisaoui self-requested a review August 30, 2024 13:01
Copy link
Contributor

@Oumaimafisaoui Oumaimafisaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Oumaimafisaoui Oumaimafisaoui merged commit 36dbea7 into master Aug 30, 2024
3 checks passed
@Oumaimafisaoui Oumaimafisaoui deleted the CON-3011-test-quest-01-ex-03 branch August 30, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants