Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CON-3030 Subject for Quest01/star-forge #2665

Merged
merged 9 commits into from
Aug 29, 2024
Merged

CON-3030 Subject for Quest01/star-forge #2665

merged 9 commits into from
Aug 29, 2024

Conversation

Oumaimafisaoui
Copy link
Contributor

@Oumaimafisaoui Oumaimafisaoui commented Jul 28, 2024 •
edited by jira bot
Loading

Solve : CON-3030

@Oumaimafisaoui Oumaimafisaoui added the 🗂️ docs Documentation label Jul 28, 2024
@Oumaimafisaoui Oumaimafisaoui requested a review from nprimo July 28, 2024 22:16
@Oumaimafisaoui Oumaimafisaoui self-assigned this Jul 28, 2024
@Oumaimafisaoui Oumaimafisaoui changed the title CON-3030 Subject for star forge CON-3030 Subject for star-forge Jul 28, 2024
@nprimo nprimo added the 🤸 skip-check-links Skip check links label Aug 6, 2024
@Oumaimafisaoui Oumaimafisaoui changed the title CON-3030 Subject for star-forge CON-3030 Subject for Quest01/star-forge Aug 7, 2024
@Oumaimafisaoui Oumaimafisaoui requested a review from nprimo August 7, 2024 13:24
nprimo
nprimo suggested changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@nprimo nprimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked if it's possible to have an exercise without solution/tests?
It's possible to "bypass" the need to submit a solution by adding a test that always pass and does not expect any file as solution

@Oumaimafisaoui Oumaimafisaoui requested a review from nprimo August 12, 2024 19:00
nprimo
nprimo suggested changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@nprimo nprimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment for a small typo / grammar fix

@Oumaimafisaoui Oumaimafisaoui requested a review from nprimo August 14, 2024 07:30
@Oumaimafisaoui Oumaimafisaoui removed the request for review from lotoussa August 27, 2024 11:35
@zanninso zanninso self-requested a review August 28, 2024 12:18
zanninso
zanninso approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@zanninso zanninso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanninso zanninso force-pushed the CON-3030-Markdown-DPxAI-Quest01-star-forge branch from 3f1f8ed to 4e937fc Compare August 29, 2024 01:20
@zanninso zanninso merged commit 04eb4c3 into master Aug 29, 2024
3 checks passed
@zanninso zanninso deleted the CON-3030-Markdown-DPxAI-Quest01-star-forge branch August 29, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nprimo nprimo nprimo approved these changes

@zanninso zanninso zanninso approved these changes

Assignees

@Oumaimafisaoui Oumaimafisaoui

Labels
🗂️ docs Documentation 🤸 skip-check-links Skip check links
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Oumaimafisaoui @nprimo @zanninso