Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CON-3026: Add subject for declare-everything #2664

Merged

Conversation

Oumaimafisaoui
Copy link
Contributor

@Oumaimafisaoui Oumaimafisaoui commented Jul 28, 2024

Solving : CON-3026

@Oumaimafisaoui Oumaimafisaoui added the 🗂️ docs Documentation label Jul 28, 2024
@Oumaimafisaoui Oumaimafisaoui requested a review from nprimo July 28, 2024 21:53
@Oumaimafisaoui Oumaimafisaoui self-assigned this Jul 28, 2024
Copy link
Contributor

@nprimo nprimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments inline + the PR is missing the tests for the exercise

There are 2 CON-3026 branches: please remove the duplicated one

@Oumaimafisaoui Oumaimafisaoui requested a review from nprimo August 6, 2024 08:36
Copy link
Contributor

@nprimo nprimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the formatting, everything else LGTM
The merge needs to be sync with:

@Oumaimafisaoui Oumaimafisaoui requested a review from nprimo August 8, 2024 08:45
@Oumaimafisaoui Oumaimafisaoui merged commit f98b491 into master Aug 27, 2024
3 checks passed
@Oumaimafisaoui Oumaimafisaoui deleted the CON-3026-markdown-DPxAI-Quest01-declare-everything branch August 27, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗂️ docs Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants